Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plotPCA test #1374

Open
wants to merge 1 commit into
base: 4.0.0
Choose a base branch
from
Open

Conversation

pavanvidem
Copy link
Collaborator

@WardDeb .npz is in .gitignore. Neverthless, I added a required .npz test input file.

@bgruening
Copy link
Member

I have a general question, would it be good to have those tests added to the current deeptools version as well. So that we can compare results?

@pavanvidem
Copy link
Collaborator Author

what do you mean by the current vesion? 3.x?

@WardDeb
Copy link
Member

WardDeb commented Jan 23, 2025

I have a general question, would it be good to have those tests added to the current deeptools version as well. So that we can compare results?

Yea, that's the idea, though only for those functionalities that changed (bamCompare / bamCoverage, computeMatrix & multiBamSummary). Note that this doesn't need to be incoporated in the current version, as for now all the 'old' functionality is still present in 4.0.0 (either through the API, or by bringing back the entrypoints..).

Note that the planemo tests at this point serve as a first checkpoint in this regard, as soon as rewrite is finished (and planemo tests hopefully pass), we can move to the more elaborate setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants