Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network plots #236

Merged
merged 18 commits into from
May 4, 2022
Merged

Network plots #236

merged 18 commits into from
May 4, 2022

Conversation

clonker
Copy link
Member

@clonker clonker commented May 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #236 (bac36d2) into main (a52464d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   93.76%   93.89%   +0.13%     
==========================================
  Files         137      138       +1     
  Lines       10841    10990     +149     
==========================================
+ Hits        10165    10319     +154     
+ Misses        676      671       -5     
Impacted Files Coverage Δ
deeptime/covariance/util/_moments.py 93.73% <ø> (ø)
deeptime/markov/msm/_markov_state_model.py 97.36% <ø> (ø)
deeptime/plots/chapman_kolmogorov.py 98.33% <ø> (+4.45%) ⬆️
deeptime/plots/util.py 100.00% <ø> (ø)
deeptime/decomposition/__init__.py 100.00% <100.00%> (ø)
deeptime/plots/__init__.py 100.00% <100.00%> (ø)
deeptime/plots/energy.py 100.00% <100.00%> (ø)
deeptime/plots/network.py 100.00% <100.00%> (ø)
deeptime/util/stats.py 96.10% <100.00%> (+0.02%) ⬆️
deeptime/util/validation.py 97.56% <100.00%> (+0.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52464d...bac36d2. Read the comment docs.

Copy link
Collaborator

@MaaikeG MaaikeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments.

Also, I tried running the plot_network.py example locally, but I'm getting an error:
File "(...)\Deeptime\deeptime\deeptime\plots\network.p
y", line 160, in cmap
from matplotlib import colormaps
ImportError: cannot import name 'colormaps' from 'matplotlib' (C:\Users\Maaike
iniconda3\envs\deeptime\lib\site-packages\matplotlib_init_.py)

I have matplotlib version 3.4.3 installed.

deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
deeptime/plots/network.py Outdated Show resolved Hide resolved
@clonker
Copy link
Member Author

clonker commented May 3, 2022

thanks! does it work now?

@clonker clonker merged commit 5299bd3 into deeptime-ml:main May 4, 2022
@clonker clonker deleted the network_plots branch May 4, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants