add device option for TAE class #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 136 136
Lines 10789 10790 +1
=======================================
+ Hits 10115 10116 +1
Misses 674 674
Continue to review full report at Codecov.
|
|
Looks good to me, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I just found the device of the TAE class is not allowed to be specified when I was playing the time-lagged auto-encoder. After checked the code, I found a self.device actually does appear in the fit function but without initialization. So I just added an option for device in the init function so that one can choose to use either cpu or gpu to train the model.