Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAM Progress bar handling #191

Merged
merged 10 commits into from
Jan 13, 2022
Merged

TRAM Progress bar handling #191

merged 10 commits into from
Jan 13, 2022

Conversation

MaaikeG
Copy link
Collaborator

@MaaikeG MaaikeG commented Jan 13, 2022

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include one or more tests for your change
  • Add yourself to AUTHORS
  • Add a new entry to the doc/source/CHANGELOG. Decide whether your change is a fix or a new feature.

@MaaikeG
Copy link
Collaborator Author

MaaikeG commented Jan 13, 2022

The notebook also needs to be updated but I will do that when I have also moved the log likelihood stuff

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #191 (f6d137f) into main (3d59ee1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         131      131           
  Lines       10467    10467           
=======================================
  Hits         9792     9792           
  Misses        675      675           
Impacted Files Coverage Δ
deeptime/markov/msm/tram/_tram.py 95.94% <100.00%> (ø)
deeptime/markov/msm/tram/_tram_dataset.py 97.07% <100.00%> (ø)
deeptime/util/callbacks.py 100.00% <100.00%> (ø)
deeptime/util/platform.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d59ee1...f6d137f. Read the comment docs.

@clonker
Copy link
Member

clonker commented Jan 13, 2022

I like it, thanks!

@clonker clonker merged commit 14f66ca into deeptime-ml:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants