Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kmeans with no iterations #189

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Conversation

thempel
Copy link
Collaborator

@thempel thempel commented Jan 12, 2022

  • more consistent with api (user expects no iterations if max_iter=0)
  • simpler to extract kmeans++ center initialization, in particular for pyemma

Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #189 (c79f070) into main (6c0d297) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         131      131           
  Lines       10468    10468           
=======================================
  Hits         9788     9788           
  Misses        680      680           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0d297...c79f070. Read the comment docs.

@clonker clonker merged commit 86eb11b into deeptime-ml:main Jan 12, 2022
@thempel thempel deleted the kmeans-noiter branch January 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants