Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tram docs and a unit test #188

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Tram docs and a unit test #188

merged 4 commits into from
Jan 12, 2022

Conversation

MaaikeG
Copy link
Collaborator

@MaaikeG MaaikeG commented Jan 12, 2022

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include one or more tests for your change
  • Add yourself to AUTHORS
  • Add a new entry to the doc/source/CHANGELOG. Decide whether your change is a fix or a new feature.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #188 (3947383) into main (6c0d297) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files         131      131              
  Lines       10468    10467       -1     
==========================================
+ Hits         9788     9790       +2     
+ Misses        680      677       -3     
Impacted Files Coverage Δ
deeptime/markov/msm/tram/_tram_dataset.py 95.90% <ø> (-1.19%) ⬇️
deeptime/markov/msm/tram/_tram.py 95.94% <100.00%> (ø)
deeptime/util/callbacks.py 100.00% <0.00%> (+31.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0d297...3947383. Read the comment docs.

Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clonker clonker merged commit 65fc482 into deeptime-ml:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants