Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nox #164

Merged
merged 34 commits into from
Nov 10, 2021
Merged

Nox #164

merged 34 commits into from
Nov 10, 2021

Conversation

clonker
Copy link
Member

@clonker clonker commented Nov 9, 2021

Introduce nox to run tests and build the package, replace conda as build and dependency management tool with pip which reduces the load on CI.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #164 (7d70177) into main (4aba392) will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   92.18%   93.17%   +0.99%     
==========================================
  Files         147      129      -18     
  Lines       10439    10318     -121     
==========================================
- Hits         9623     9614       -9     
+ Misses        816      704     -112     
Impacted Files Coverage Δ
deeptime/data/_drunkards_walk_simulator.py 95.37% <0.00%> (-0.13%) ⬇️
deeptime/data/_bickley_simulator.py 98.86% <0.00%> (-0.02%) ⬇️
deeptime/data/_pbf_simulator.py 100.00% <0.00%> (ø)
...eptime/markov/tools/estimation/sparse/mle/setup.py
deeptime/markov/hmm/init/setup.py
deeptime/decomposition/setup.py
deeptime/markov/tools/estimation/setup.py
deeptime/markov/tools/setup.py
deeptime/numeric/setup.py
deeptime/covariance/util/covar_c/setup.py
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aba392...7d70177. Read the comment docs.

@clonker clonker requested a review from marscher November 9, 2021 14:27
@marscher
Copy link
Collaborator

marscher commented Nov 9, 2021

Nice change, as it reduces CI time. I guess using mamba would also have a similar effect.
I'd keep at least one conda job to make your life easier when deploying to conda-forge ;)

@clonker
Copy link
Member Author

clonker commented Nov 9, 2021

good point, thx!

@clonker clonker merged commit 2aeb674 into deeptime-ml:main Nov 10, 2021
@clonker clonker deleted the nox branch November 10, 2021 16:57
@marscher
Copy link
Collaborator

congratz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants