-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml
with legacy build backend to keep most logic in setup.py
#7033
base: master
Are you sure you want to change the base?
Conversation
@mrwyattii we just went through some of this with arctic training. If it’s helpful @loadams let’s discuss on slack a bit. There’s a ton that’s currently happening in setup.py, this could be a big lift? But I agree, needs to happen! |
Signed-off-by: Logan Adams <[email protected]>
…ently, so we aren't seeing cupy installed. Signed-off-by: Logan Adams <[email protected]>
Signed-off-by: Logan Adams <[email protected]>
pyproject.toml
with legacy build backend to keep most logic in setup.py
Edit: this is no longer correct with latest changes. The current problem is that the logic inside setup.py aside from the call to |
--no-build-isolation
The main goal of this effort is to become compliant with the coming changes to pip in 25.1 listed here which will break editable installs. Future PRs will fully move from
setup.py
topyproject.toml
Fixes: #7031