Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml with legacy build backend to keep most logic in setup.py #7033

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

loadams
Copy link
Collaborator

@loadams loadams commented Feb 13, 2025

  • Test all build cases this needs to support.
  • Test Windows builds/support.
  • Confirm pre-compiling ops - works with --no-build-isolation
  • Test commit hashes are added to dev builds

The main goal of this effort is to become compliant with the coming changes to pip in 25.1 listed here which will break editable installs. Future PRs will fully move from setup.py to pyproject.toml

Fixes: #7031

@jeffra
Copy link
Collaborator

jeffra commented Feb 14, 2025

@mrwyattii we just went through some of this with arctic training. If it’s helpful @loadams let’s discuss on slack a bit. There’s a ton that’s currently happening in setup.py, this could be a big lift? But I agree, needs to happen!

@loadams loadams changed the title Add pyproject.toml Add pyproject.toml with legacy build backend to keep most logic in setup.py Feb 19, 2025
@loadams
Copy link
Collaborator Author

loadams commented Feb 19, 2025

Edit: this is no longer correct with latest changes.

The current problem is that the logic inside setup.py aside from the call to setup() isn't run. This means that we don't append cupy into the requirements file, and tests fail as a result. This impacts other parts of the build experience, so we will need to do more work to switch to a modern build backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix - Update DeepSpeed to be PEP517 compliant, update to pyproject.toml
3 participants