Remove Duplicate Declaration of pandas in Dockerfile
#6959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Jan 17, 2025
siqi654321
pushed a commit
to siqi654321/DeepSpeed
that referenced
this pull request
Feb 7, 2025
) ### Description This pull request removes the redundant installation of `pandas` from the `Dockerfile`. It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the `Dockerfile`. https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124 https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135 ### Changes Removed the duplicate pandas installation line from the `RUN pip install` command. Signed-off-by: siqi <[email protected]>
traincheck-team
pushed a commit
to traincheck-team/DeepSpeed
that referenced
this pull request
Feb 9, 2025
) ### Description This pull request removes the redundant installation of `pandas` from the `Dockerfile`. It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the `Dockerfile`. https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124 https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135 ### Changes Removed the duplicate pandas installation line from the `RUN pip install` command.
gyou2021
pushed a commit
to gyou2021/DeepSpeed
that referenced
this pull request
Feb 18, 2025
) ### Description This pull request removes the redundant installation of `pandas` from the `Dockerfile`. It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the `Dockerfile`. https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124 https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135 ### Changes Removed the duplicate pandas installation line from the `RUN pip install` command. Signed-off-by: gyou2021 <[email protected]>
gyou2021
pushed a commit
to gyou2021/DeepSpeed
that referenced
this pull request
Feb 18, 2025
) ### Description This pull request removes the redundant installation of `pandas` from the `Dockerfile`. It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the `Dockerfile`. https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124 https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135 ### Changes Removed the duplicate pandas installation line from the `RUN pip install` command. Signed-off-by: gyou2021 <[email protected]>
ys950902
pushed a commit
to ys950902/DeepSpeed
that referenced
this pull request
Mar 6, 2025
) ### Description This pull request removes the redundant installation of `pandas` from the `Dockerfile`. It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the `Dockerfile`. https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124 https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135 ### Changes Removed the duplicate pandas installation line from the `RUN pip install` command. Signed-off-by: yisheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the redundant installation of
pandasfrom theDockerfile.It was previously declared twice, and this update eliminates the duplicate entry, improving the clarity and maintainability of the
Dockerfile.https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L124
https://github.com/microsoft/DeepSpeed/blob/018ece5af2d89a11a4a235f81f94496c78b4f990/docker/Dockerfile#L135
Changes
Removed the duplicate pandas installation line from the
RUN pip installcommand.