Monitor was always enabled causing performance degradation #5633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean expression for the monitor to be enabled has been incorrect, since instead of using `enabled` field it used the comet configuration object, making the expression always True. This caused performance degradation (we observed >10%) as it erroneously invoked the events logging flow along with the expensive calculation of loss.mean().item().
tjruwase
approved these changes
Jun 9, 2024
|
http connection issue caused cpu-torch-latest to fail |
|
@deepcharm |
loadams
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Boolean expression for the monitor to be enabled was incorrect, as instead of using the
enabledfield, it used the comet configuration object, making the expression always True.This caused performance degradation (we've observed ~10% drop) as it erroneously invoked the events logging flow along with the expensive calculation of
loss.mean().item().