fix MegatronLayerPolicy to be compatible with the newest ParallelTransformerLayer #4236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently in DeepSpeed, will try to get
client_module.attention
while the actualParallelTransformerLayer
has noattention
butself_attention
according to this file https://github.com/microsoft/Megatron-DeepSpeed/blob/main/megatron/model/transformer.py#L927The whole structure is:

Solution
I followed existed way by modifying version attribute to make it compatible with the newest
ParallelTransformerLayer
, and changeattention
toself_attention
.But I'm not sure whether
ParallelTransformerLayer
is changed or it's a new module, which means changingMegatronLayerPolicy.version
is correct.