Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pip --use-feature #419

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Remove pip --use-feature #419

merged 1 commit into from
Sep 17, 2020

Conversation

jeffra
Copy link
Collaborator

@jeffra jeffra commented Sep 17, 2020

Several users have reported issues with this for some reason :(

@jeffra jeffra merged commit 5bc7d4e into master Sep 17, 2020
@jeffra jeffra deleted the jeffra-patch-1 branch September 17, 2020 23:57
@g-karthik
Copy link

@jeffra yeah --use-feature was causing some issues, but it seems they went away after upgrading pip.

Maybe you could enforce pip version constraints in case this flag is needed again in future?

@ShadenSmith
Copy link
Contributor

Hi @g-karthik, fortunately this feature just enabled what will become pip's dependency resolution mode next month. I enabled it here thinking it was present in more pip versions, but I can now see it isn't lol. We work with it enabled and disabled, which is the important thing. We shouldn't need to enable it again.

I'm in the middle of moving to a new place and will get back to your build update thread asap. @jeffra is also working through it as you can see 🙂. Thanks so much for the detailed feedback!

@jeffra
Copy link
Collaborator Author

jeffra commented Sep 18, 2020

Hi @g-karthik, thanks so much for all your excellent feedback! We for some reason saw some internal users having issues with the flag also. I agree, ideally we could branch on pip version to enable the flag though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants