Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate config validation error on inference unit tests #4107

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mrwyattii
Copy link
Contributor

@mrwyattii mrwyattii commented Aug 8, 2023

huggingface/transformers#25381 Added validation to generate config in transformers. Updating our inference kwargs to avoid validation errors:

ValueError: `do_sample` is set to `False`. However, temperature is set to 0.9 -- this flag is only used in sample-based generation modes. Set `do_sample=True` or unset temperature to continue.

@mrwyattii mrwyattii added this pull request to the merge queue Aug 8, 2023
@mrwyattii mrwyattii removed this pull request from the merge queue due to a manual request Aug 8, 2023
@mrwyattii mrwyattii merged commit 975bcbc into master Aug 8, 2023
@mrwyattii mrwyattii deleted the mrwyattii/fix-generate-params branch August 8, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants