-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rnn flop profiler to compute flops instead of macs #3833
Fix rnn flop profiler to compute flops instead of macs #3833
Conversation
@cli99 what should I do for it to be merged? it seems all checks are passing, auto-merge is on, yet it does not get merged? sorry for the noob question but I am not familiar with GitHub and forking. |
@pinstripe-potoroo, apologies for the silence. This PR is already approved and should merged soon. |
Just to explain a bit more. The blockage is due to the high rate of merges on the repo, and each merge makes other PRs out-of-date. Enabling auto-merge can help, but not always. We appreciate your contributions and will get both PRs merged asap. Thanks! |
This MR is related to the issue I recently opened: #3816
It implements the simple fix I proposed there, which simply computes FLOPs instead of MACs.