Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rnn flop profiler to compute flops instead of macs #3833

Merged
merged 13 commits into from
Jul 6, 2023
Merged

Fix rnn flop profiler to compute flops instead of macs #3833

merged 13 commits into from
Jul 6, 2023

Conversation

pinstripe-potoroo
Copy link
Contributor

This MR is related to the issue I recently opened: #3816

It implements the simple fix I proposed there, which simply computes FLOPs instead of MACs.

@pinstripe-potoroo pinstripe-potoroo requested a review from cli99 as a code owner June 28, 2023 08:49
@cli99 cli99 enabled auto-merge (squash) June 28, 2023 18:45
@pinstripe-potoroo
Copy link
Contributor Author

@cli99 I am sorry I do not understand what I need to do to enable the merge to happen? I clicked a button that said "update branch" which I think pulled master (from the original repo) into this branch. But then it says merging is still blocked. This is also true with my other MR: #3834

@cli99 cli99 disabled auto-merge June 29, 2023 17:28
@pinstripe-potoroo
Copy link
Contributor Author

@cli99 what should I do for it to be merged? it seems all checks are passing, auto-merge is on, yet it does not get merged? sorry for the noob question but I am not familiar with GitHub and forking.

@pinstripe-potoroo
Copy link
Contributor Author

I am sorry to insist on my above comment, but I am really not sure if I understand the process. Is anything else expected from me in order to get this MR (and its companion MR #3834) merged? @cli99 @tjruwase

@tjruwase
Copy link
Contributor

tjruwase commented Jul 3, 2023

@pinstripe-potoroo, apologies for the silence. This PR is already approved and should merged soon.

@tjruwase
Copy link
Contributor

tjruwase commented Jul 3, 2023

@cli99 I am sorry I do not understand what I need to do to enable the merge to happen? I clicked a button that said "update branch" which I think pulled master (from the original repo) into this branch. But then it says merging is still blocked. This is also true with my other MR: #3834

Just to explain a bit more. The blockage is due to the high rate of merges on the repo, and each merge makes other PRs out-of-date. Enabling auto-merge can help, but not always. We appreciate your contributions and will get both PRs merged asap. Thanks!

@cli99 cli99 enabled auto-merge (squash) July 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants