Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hybrid_engine: check tuple size when fusing lora params #3311

Merged
merged 3 commits into from
Apr 24, 2023
Merged

hybrid_engine: check tuple size when fusing lora params #3311

merged 3 commits into from
Apr 24, 2023

Conversation

adammoody
Copy link
Contributor

@adammoody adammoody commented Apr 20, 2023 •
edited
Loading

As written, I believe the if conditions might always evaluate to True, since the body of the for loop would not execute if the lora_params list is 0-length. I think the intent here was to verify that the tuple has three elements.

@adammoody
Copy link
Contributor Author

@tjruwase , here is a PR for the lora_param question.

@tjruwase tjruwase requested a review from cmikeh2 April 20, 2023 15:47
@tjruwase tjruwase merged commit c9196b6 into deepspeedai:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@jeffra jeffra Awaiting requested review from jeffra

@cmikeh2 cmikeh2 Awaiting requested review from cmikeh2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adammoody @tjruwase @loadams