Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen unit test performance assert #352

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

mrwyattii
Copy link
Contributor

We are seeing failures on some runs with the A6000 runner on the DeepSpeed repo. This is due to the multi-replica test having slightly worse performance on that machine that others we have tested. Providing a wider range of accepted performance for now until we figure out why that machine is behaving differently than others.

Example failure:

FAILED test_deployment.py::test_multi_replica[query0-nofail-test-dep-local-50050-False-28080-text-generation-facebook/opt-125m-None-True-2] - AssertionError: two queries should take about the same time as one query
assert 0.8824012279510498 == 0.706052303314209 ± 7.1e-02
  comparison failed
  Obtained: 0.8824012279510498
  Expected: 0.706052303314209 ± 7.1e-02

@loadams

@mrwyattii mrwyattii requested a review from awan-10 as a code owner December 8, 2023 19:22
@mrwyattii mrwyattii merged commit c4dfa56 into main Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant