chore: update ruff version in pre-commit hook #8746
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
While investigating formatting issues in #8745,
I noticed an inconsistency:
format
job in test workflow uses the latest version of ruffThis can sometimes create this cycle:
format
job failshatch run format
(because pre-commit hook did not take care of it)Proposed Changes:
Notes for the reviewer
In the long run, there could be better ways to fix this problem, such as running
pre-commit autoupdate
in the CI or pinning ruff also in our pyproject file.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.