refactor: create_tool_from_function + tool decorator
#8697
+416
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
commented
Jan 9, 2025
| return Tool(name=name or function.__name__, description=tool_description, parameters=schema, function=function) | ||
|
|
||
|
|
||
| def tool(function: Callable) -> Tool: |
There was a problem hiding this comment.
the decorator essentially mirrors create_tool_from_function, but keeping them separate allows for potential future customization of the decorator.
anakin87
requested review from
dfokina,
julian-risch and
vblagoje
and removed request for
a team
Pull Request Test Coverage Report for Build 12695370849Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12695378991Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12695708412Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12695790549Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Since we are introducing some subclasses of
Tool(ComponentTool,OpenAPIToolin the future, ...), theTool.from_functionclass method becomes inappropriate. These subclasses would inherit the method, potentially leading to unintended behaviors (e.g.ComponentTool.from_functionmakes no sense).To address this, I'm proposing a replacement:
create_tool_from_functionutility function (+ atooldecorator).Proposed Changes:
Tool.from_functionclass method with acreate_tool_from_functionutility function.tooldecorator, to simplify programmatic use casesHow did you test it?
CI, new tests
Notes for the reviewer
I also reorganized the code by moving functionalities into separate modules.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.