-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default_headers for azure embeddings #8535
feat: add default_headers for azure embeddings #8535
Conversation
Benjamin Nuernberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Pull Request Test Coverage Report for Build 12685298781Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@nuernber thanks for the contribution. Can you please sign the CLA? |
@nuernber left a few comments - one question still, is the |
@davidsbatista |
Co-authored-by: David S. Batista <[email protected]>
@nuernber Thank you for contributing to Haystack! Could you please sign the contributor license agreement (CLA), otherwise we cannot merge this PR. |
Related Issues
Proposed Changes:
Follows the logic from
AzureOpenAIGenerator
fordefault_headers
:haystack/haystack/components/generators/azure.py
Line 71 in 852900d
and
haystack/haystack/components/generators/azure.py
Line 152 in 852900d
How did you test it?
Ran the unit tests and also tested with my Azure set up that uses a subscription key.
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.