Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default_headers for azure embeddings #8535

Closed

Conversation

nuernber
Copy link

Related Issues

Proposed Changes:

Follows the logic from AzureOpenAIGenerator for default_headers:

default_headers: Optional[Dict[str, str]] = None,

and
default_headers=self.default_headers,

How did you test it?

Ran the unit tests and also tested with my Azure set up that uses a subscription key.

Notes for the reviewer

Checklist

@nuernber nuernber requested review from a team as code owners November 12, 2024 03:37
@nuernber nuernber requested review from dfokina and Amnah199 and removed request for a team November 12, 2024 03:37
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Benjamin Nuernberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Nov 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 12685298781

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 371 unchanged lines in 35 files lost coverage.
  • Overall coverage increased (+0.9%) to 91.026%

Files with Coverage Reduction New Missed Lines %
components/generators/chat/azure.py 1 92.86%
components/preprocessors/document_cleaner.py 1 98.1%
components/preprocessors/document_splitter.py 1 99.51%
components/retrievers/sentence_window_retriever.py 1 98.08%
components/builders/answer_builder.py 2 96.83%
core/component/component.py 2 98.75%
dataclasses/chat_message.py 2 99.09%
utils/callable_serialization.py 2 95.0%
components/builders/chat_prompt_builder.py 3 95.89%
components/converters/pypdf.py 3 95.95%
Totals Coverage Status
Change from base Build 11781566054: 0.9%
Covered Lines: 8571
Relevant Lines: 9416

💛 - Coveralls

@Amnah199
Copy link
Contributor

@nuernber thanks for the contribution. Can you please sign the CLA?

@davidsbatista
Copy link
Contributor

@nuernber left a few comments - one question still, is the default_header an optional or mandatory parameter according to the Azureus API?

@Amnah199
Copy link
Contributor

Co-authored-by: David S. Batista <[email protected]>
@julian-risch
Copy link
Member

@nuernber Thank you for contributing to Haystack! Could you please sign the contributor license agreement (CLA), otherwise we cannot merge this PR.
#8535 (comment)

@Amnah199
Copy link
Contributor

Amnah199 commented Jan 9, 2025

@nuernber thanks for the contribution. We created a fresh PR #8699 to add default_headers as a keyword parameter to embedders. This is done to prevent too-many-positional-arguments in future.
Hence, closing this PR.

@Amnah199 Amnah199 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default_headers for AzureOpenAIDocumentEmbedder and AzureOpenAITextEmbedder
6 participants