Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add boilerpy3 to the core dependencies #6544

Merged
merged 5 commits into from
Dec 14, 2023
Merged

chore: add boilerpy3 to the core dependencies #6544

merged 5 commits into from
Dec 14, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 14, 2023

Related Issues

The additional pip install boilerpy3 is ubiquitous in our docs and code examples, let's just make it part of haystack-ai

Proposed Changes:

Add boilerpy3 as a dependency, it's only 22kb

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner December 14, 2023 08:59
@masci masci requested review from julian-risch and removed request for a team December 14, 2023 08:59
@masci masci self-assigned this Dec 14, 2023
@github-actions github-actions bot added the type:documentation Improvements on the docs label Dec 14, 2023
@anakin87
Copy link
Member

Sorry to jump in... (this is also related to my work on Converters)

Can you also remove boilerpy3 from tests workflow?

@julian-risch
Copy link
Member

Just saw the same :D Here is my link:

run: pip install .[dev,audio] langdetect transformers[torch,sentencepiece]==4.35.2 'sentence-transformers>=2.2.0' pypdf markdown-it-py mdit_plain tika 'azure-ai-formrecognizer>=3.2.0b2' boilerpy3

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Just the release note check is failing. And the linter complained:

haystack/components/converters/html.py:9:0: C0411: third party import "from boilerpy3 import extractors" should be placed before "from haystack import Document, component" (wrong-import-order)
haystack/components/converters/html.py:7:0: W0611: Unused LazyImport imported from haystack.lazy_imports (unused-import)

Once this is merged and we released a new Haystack version, we can remove the boilerpy3 installation from "Advent of Haystack: Day 10" challenge.

@masci masci requested a review from a team as a code owner December 14, 2023 10:13
@masci masci requested review from dfokina and removed request for a team December 14, 2023 10:13
@masci masci merged commit bc45170 into main Dec 14, 2023
18 checks passed
@masci masci deleted the massi/boilerpy3 branch December 14, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants