-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add boilerpy3 to the core dependencies #6544
Conversation
Sorry to jump in... (this is also related to my work on Converters) Can you also remove |
Just saw the same :D Here is my link: haystack/.github/workflows/tests.yml Line 101 in 8d9c3de
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Just the release note check is failing. And the linter complained:
haystack/components/converters/html.py:9:0: C0411: third party import "from boilerpy3 import extractors" should be placed before "from haystack import Document, component" (wrong-import-order)
haystack/components/converters/html.py:7:0: W0611: Unused LazyImport imported from haystack.lazy_imports (unused-import)
Once this is merged and we released a new Haystack version, we can remove the boilerpy3 installation from "Advent of Haystack: Day 10" challenge.
Related Issues
The additional
pip install boilerpy3
is ubiquitous in our docs and code examples, let's just make it part ofhaystack-ai
Proposed Changes:
Add
boilerpy3
as a dependency, it's only 22kbHow did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.