Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not dump pipeline graph into the debug payload #6528

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: do not dump pipeline graph into the debug payload #6528

merged 2 commits into from
Dec 12, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 12, 2023

Related Issues

Proposed Changes:

Remove the code with the problematic deepcopy, users can still draw() the pipeline after a debug run

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner December 12, 2023 10:08
@masci masci requested review from julian-risch and removed request for a team December 12, 2023 10:08
@github-actions github-actions bot added topic:core type:documentation Improvements on the docs labels Dec 12, 2023
@masci masci requested a review from a team as a code owner December 12, 2023 10:13
@masci masci requested review from dfokina and removed request for a team December 12, 2023 10:13
julian-risch
julian-risch approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@masci masci merged commit a55024b into main Dec 12, 2023
7 checks passed
@masci masci deleted the massi/6265 branch December 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:core type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

debug=True in pipeline.run creates errors with LinkContentFetcher
2 participants
@masci @julian-risch