-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AWS bedrock embeddings to embedding encoder #6406
Conversation
Pull Request Test Coverage Report for Build 6977754646
💛 - Coveralls |
Hey @jlonge4, we are very busy with the upcoming 2.0 release these days. So probably the review process may be a bit long... Please bear with us. |
@anakin87 No worries! I totally understand |
@tstadel no worries I appreciate the feedback! Everything should be implemented, however some weird failures related to files I hadn't even touched that I didn't get last time. |
@anakin87 was that a merge in the wrong direction? 😅 |
I fixed mypy and pylint errors. In general, it looks good, but I haven't tried these changes locally.... @tstadel can you take another look? |
@anakin87 @jlonge4 I did some final refactorings and fixed two things:
Also for cohere we use batch mode now. I made some final tests locally to ensure doc and query embeddings are working with titan and cohere models. So from my side we can merge now :-) |
@anakin87 wait I've found another thing to improve:
|
@anakin87 ok now we're good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed Changes:
Add AWS Bedrock embedding retriever to support embedding queries/documents with titan embeddings model.
How did you test it?
manual verification
Notes for the reviewer
haystack/nodes/retriever/embedding_encoder
haystack/nodes/retriever/dense
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.