-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add batch_size to FAISS __init__ #6401
Conversation
@pandasar13 Could you please move the release note you created to |
Pull Request Test Coverage Report for Build 6972059698Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for your 1st contribution to Haystack! 💟
I will merge this PR when the tests pass...
Related Issues
Proposed Changes:
Added batch_size to the init method of FAISSDocumentStore and modified the functions that use batch_size to either specify batch_size or use self.batch_size.
This way batch_size can be specified in the init method, being consistent with other document stores (e.g. Weaviate, Opensearch)
How did you test it?
manual verification
Notes for the reviewer
Checklist
I have read the contributors guidelines and the
code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue