-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add microsoft pptx file converter #6399
Conversation
Pull Request Test Coverage Report for Build 6971610642Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good!
I see some small opportunities for improvements
(I added suggestions.)
…yaml Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very good!
Once the tests pass, I will merge it...
Thanks for your 1st Haystack contribution 🥳 🎈
@anakin87 changes committed, thanks so much for all of your patience man, as well as the improvements! Thanks to you perhaps my next one will go much more smoothly lol |
Proposed Changes:
Adding microsoft pptx converter to convert slides to text.
How did you test it?
Manual verification
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.