Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add microsoft pptx file converter #6399

Merged
merged 10 commits into from
Nov 23, 2023
Merged

feat: add microsoft pptx file converter #6399

merged 10 commits into from
Nov 23, 2023

Conversation

jlonge4
Copy link
Contributor

@jlonge4 jlonge4 commented Nov 23, 2023

Proposed Changes:

Adding microsoft pptx converter to convert slides to text.

How did you test it?

Manual verification

Notes for the reviewer

Checklist

@jlonge4 jlonge4 requested a review from a team as a code owner November 23, 2023 14:49
@jlonge4 jlonge4 requested review from ZanSara and removed request for a team November 23, 2023 14:49
@anakin87 anakin87 requested review from anakin87 and removed request for ZanSara November 23, 2023 14:52
@jlonge4 jlonge4 requested a review from a team as a code owner November 23, 2023 14:55
@jlonge4 jlonge4 requested review from dfokina and removed request for a team November 23, 2023 14:55
@coveralls
Copy link
Collaborator

coveralls commented Nov 23, 2023

Pull Request Test Coverage Report for Build 6971610642

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 40.223%

Files with Coverage Reduction New Missed Lines %
nodes/file_converter/init.py 1 88.89%
Totals Coverage Status
Change from base Build 6971133323: 0.07%
Covered Lines: 10688
Relevant Lines: 26572

💛 - Coveralls

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good!

I see some small opportunities for improvements
(I added suggestions.)

haystack/nodes/file_converter/pptx.py Outdated Show resolved Hide resolved
@anakin87 anakin87 self-requested a review November 23, 2023 15:16
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, very good!

Once the tests pass, I will merge it...

Thanks for your 1st Haystack contribution 🥳 🎈

@jlonge4
Copy link
Contributor Author

jlonge4 commented Nov 23, 2023

@anakin87 changes committed, thanks so much for all of your patience man, as well as the improvements! Thanks to you perhaps my next one will go much more smoothly lol

@anakin87 anakin87 merged commit c44e2cf into deepset-ai:main Nov 23, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants