Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove pydoc-markdown from dev dependencies #6398

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Nov 23, 2023

Related Issues

Fixed #6119

Proposed Changes:

Remove pydoc-markdown dependency from dev extra.

pydoc-markdown is only used in readme_sync.yml workflow and is also installed via docs/pydoc/requirements.txt ignoring Haystack pyproject.toml.

So it's safe to remove.

This also unpins fastapi version in rest_api.

How did you test it?

There's nothing much to test really.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza self-assigned this Nov 23, 2023
@silvanocerza silvanocerza requested a review from a team as a code owner November 23, 2023 14:36
@silvanocerza silvanocerza requested review from anakin87 and removed request for a team November 23, 2023 14:36
@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 23, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 23, 2023

Pull Request Test Coverage Report for Build 6971173188

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 40.15%

Files with Coverage Reduction New Missed Lines %
preview/components/converters/pypdf.py 21 0.0%
Totals Coverage Status
Change from base Build 6969071273: -0.01%
Covered Lines: 10655
Relevant Lines: 26538

💛 - Coveralls

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@anakin87 anakin87 merged commit 604b177 into main Nov 23, 2023
60 checks passed
@anakin87 anakin87 deleted the remove-pydoc-markdown-dep branch November 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency conflict: fastapi==0.104.0 and pydoc-markdown==4.8.2
3 participants