Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Pytest Fixtures #639

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Cleanup Pytest Fixtures #639

merged 9 commits into from
Dec 14, 2020

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Nov 30, 2020 •
edited
Loading

This PR removes redundant fixtures for document stores and retrievers.

@tanaysoni tanaysoni changed the title WIP: Cleanup test fixtures for document stores Cleanup test fixtures for document stores Nov 30, 2020
@tanaysoni tanaysoni self-assigned this Nov 30, 2020
@tanaysoni tanaysoni requested a review from tholor November 30, 2020 11:03
@tanaysoni tanaysoni mentioned this pull request Nov 30, 2020
Merged
lalitpagaria
lalitpagaria reviewed Dec 2, 2020
View reviewed changes
test/conftest.py Outdated Show resolved Hide resolved
lalitpagaria
lalitpagaria suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment about faiss_document_store. All other changes are fine from myside.

@tanaysoni tanaysoni force-pushed the cleanup-pytest-fixture branch from a8bead7 to dadd0a5 Compare December 4, 2020 10:55
@lalitpagaria lalitpagaria mentioned this pull request Dec 5, 2020
Merged
@tanaysoni tanaysoni force-pushed the cleanup-pytest-fixture branch from 6880d9c to 99bf776 Compare December 10, 2020 16:28
@tanaysoni tanaysoni requested a review from tholor December 14, 2020 11:50
@tanaysoni tanaysoni changed the title Cleanup test fixtures for document stores Cleanup Pytest Fixtures Dec 14, 2020
@tanaysoni tanaysoni merged commit 33fe597 into master Dec 14, 2020
@tanaysoni tanaysoni deleted the cleanup-pytest-fixture branch December 14, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitpagaria lalitpagaria lalitpagaria requested changes

@tholor tholor tholor approved these changes

Assignees

@tanaysoni tanaysoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanaysoni @tholor @lalitpagaria