Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade canals to 0.10.1 #6309

Merged
merged 21 commits into from
Nov 17, 2023
Merged

feat: upgrade canals to 0.10.1 #6309

merged 21 commits into from
Nov 17, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Nov 15, 2023 •
edited
Loading

Proposed Changes:

  • Upgrade canals to 0.10.1

How did you test it?

Local tests, CI

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6903655413

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 40.474%
Files with Coverage Reduction New Missed Lines %
preview/document_stores/decorator.py 6 0.0%
Totals Coverage Status
Change from base Build 6902028938: -0.001%
Covered Lines: 10615
Relevant Lines: 26227
💛 - Coveralls

@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Nov 16, 2023
@ZanSara ZanSara marked this pull request as ready for review November 17, 2023 11:42
@ZanSara ZanSara requested review from a team as code owners November 17, 2023 11:42
@ZanSara ZanSara removed the request for review from a team November 17, 2023 11:42
@ZanSara ZanSara requested a review from vblagoje November 17, 2023 11:42
@ZanSara ZanSara changed the title feat: upgrade canals to 0.10.0 feat: upgrade canals to 0.10.1 Nov 17, 2023
vblagoje
vblagoje approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I suppose we can iron out any kinks that we could have possibly overlooked.

@ZanSara ZanSara merged commit dfc1d45 into main Nov 17, 2023
80 checks passed
@ZanSara ZanSara deleted the canals-0.10.0 branch November 17, 2023 13:46
@ZanSara ZanSara mentioned this pull request Nov 20, 2023
Closed
vblagoje pushed a commit that referenced this pull request Nov 22, 2023
@ZanSara @vblagoje
feat: upgrade canals to 0.10.1 (#6309)
446acb2 
* upgrade canals

* reno

* trigger preview e2e

* bump canals

* fix decorator

* fix test

* test factory

* tests inmemory

* tests writer

* test audio

* tests builders

* tests caching

* tests embedders

* tests converters

* tests generators

* tests rankers

* tests retrievers

* fix pipeline and telemetry tests

* remove trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:build/distribution topic:dependencies topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanSara @coveralls @vblagoje