Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting checks for shell scripts #627

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add formatting checks for shell scripts #627

merged 1 commit into from
Nov 26, 2020

Conversation

icy
Copy link
Contributor

@icy icy commented Nov 26, 2020

Let's add some small formatting checks for scripts. Small step toward more strict checks

@tholor tholor requested a review from tanaysoni November 26, 2020 12:52
@tanaysoni
Copy link
Contributor

Hi @icy, thank you for the PR! It'd be useful when we add more shell scripts in the future.

@tanaysoni tanaysoni merged commit 0edd127 into deepset-ai:master Nov 26, 2020
@tanaysoni tanaysoni changed the title ops: add some formatting checks [now: shellchecks] Add formatting checks for shell scripts Nov 26, 2020
@icy icy deleted the ops_add_some_formattin_checks branch November 26, 2020 13:55
@icy
Copy link
Contributor Author

icy commented Nov 27, 2020

Hi @icy, thank you for the PR! It'd be useful when we add more shell scripts in the future.

Thanks for your approval.

I'd like to have this part

run on my laptop. Do you think that's nice? I can send a quick PR which contains new shell script ; GithubAction will invoke that script same way as you see in this PR.

Thx again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants