fix: make JoinDocuments correctly handle duplicate documents w null scores
#6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina,
silvanocerza and
masci
and removed request for
a team
github-actions
bot
added
topic:pipeline
topic:tests
type:documentation
anakin87
commented
Nov 9, 2023
| * concatenate: combine the documents from multiple nodes. Any duplicate documents are discarded. | ||
| The score is only determined by the last node that outputs the document. | ||
| * concatenate: combine the documents from multiple nodes. | ||
| In case of duplicate documents, the one with the highest score is kept. |
There was a problem hiding this comment.
This is not a breaking change.
I'm just documenting a behavior that was already introduced in #5970 (maybe that was a breaking change).
Pull Request Test Coverage Report for Build 6811802313
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
JoinDocumentsnow fails if any document is without a score #6253When using
JoinDocumentswithjoin_mode=concatenate(default) and passing duplicate documents, including some with a null score, this node raised an exception.Proposed Changes:
How did you test it?
New unit test, CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.