Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin openai<1 #6244

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: pin openai<1 #6244

merged 1 commit into from
Nov 6, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 6, 2023

Related Issues

OpenAI SDK 1.0.0 was recently released
and some things are breaking: (e.g., https://github.com/deepset-ai/haystack/actions/runs/6773389495/job/18408515828)

Proposed Changes:

  • temporarily pin openai<1

How did you test it?

CI

Checklist

@anakin87 anakin87 requested a review from a team as a code owner November 6, 2023 16:46
@anakin87 anakin87 requested review from silvanocerza and removed request for a team November 6, 2023 16:46
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 6, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6773849865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.599%
Totals Coverage Status
Change from base Build 6773389498: 0.0%
Covered Lines: 10497
Relevant Lines: 25855
💛 - Coveralls

@anakin87 anakin87 requested a review from masci November 6, 2023 17:07
@anakin87 anakin87 merged commit 9b76acb into main Nov 6, 2023
@anakin87 anakin87 deleted the pin-openai-lt-1 branch November 6, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza silvanocerza is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @masci