Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use add_isolated_node_eval of eval_batch in run_batch #5223

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

bogdankostic
Copy link
Contributor

Related Issues

  • fixes n/a

Proposed Changes:

This PR adds add_isolated_node_eval of eval_batch to run_batch parameters. It fixes a bug introduced in #5001.

How did you test it?

I added a unit test.

Notes for the reviewer

Checklist

@bogdankostic bogdankostic requested a review from a team as a code owner June 28, 2023 14:23
@bogdankostic bogdankostic requested review from vblagoje, ZanSara, a team and anakin87 and removed request for a team June 28, 2023 14:23
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5402272134

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 110 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 44.055%

Files with Coverage Reduction New Missed Lines %
pipelines/base.py 110 40.61%
Totals Coverage Status
Change from base Build 5391855155: 0.08%
Covered Lines: 10067
Relevant Lines: 22851

💛 - Coveralls

@ZanSara ZanSara merged commit ed1bad1 into main Jun 28, 2023
@ZanSara ZanSara deleted the fix_isolated_node_eval branch June 28, 2023 14:51
anakin87 pushed a commit that referenced this pull request Jun 28, 2023
* Fix isolated node eval in eval_batch

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants