Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small improvement to pipeline v2 tests #5153

Merged
merged 3 commits into from
Jun 16, 2023
Merged

fix: small improvement to pipeline v2 tests #5153

merged 3 commits into from
Jun 16, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jun 15, 2023

Related Issues

Small bug found in pair-programming with @vblagoje

Proposed Changes:

  • adds a missing return statements
  • improves a test to make sure the pipeline returns

How did you test it?

  • local tests run

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner June 15, 2023 14:42
@ZanSara ZanSara requested review from anakin87, vblagoje, a team and silvanocerza and removed request for a team June 15, 2023 14:42
@github-actions github-actions bot added the type:documentation Improvements on the docs label Jun 15, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jun 15, 2023

Pull Request Test Coverage Report for Build 5281330094

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 42.287%

Files with Coverage Reduction New Missed Lines %
preview/pipeline.py 3 90.91%
Totals Coverage Status
Change from base Build 5280122921: 0.0%
Covered Lines: 9543
Relevant Lines: 22567

💛 - Coveralls

@ZanSara ZanSara merged commit f52477d into main Jun 16, 2023
@ZanSara ZanSara deleted the v2-pipeline-tests branch June 16, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants