chore: remove safe_import and all usages
#5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:crawler
topic:document_store
topic:elasticsearch
topic:faiss
topic:file_converter
topic:opensearch
topic:pinecone
topic:sql
topic:weaviate
type:documentation
Pull Request Test Coverage Report for Build 5376570007
💛 - Coveralls |
bogdankostic
suggested changes
Jun 23, 2023
| @@ -62,6 +56,7 @@ def _estimate_extension(self, file_path: Path) -> str: | |||
| :param file_path: the path to extract the extension from | |||
| """ | |||
| try: | |||
| magic_import.check() | |||
There was a problem hiding this comment.
Previously, we were just logging a debug message if magic could not have been imported, this will now probably raise an error - is this intended?
There was a problem hiding this comment.
Ah good point... I added it to the try-catch block but then I didn't catch the proper error 😅 I'll fix line 62 to catch this one too!
Co-authored-by: bogdankostic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
safe_importand all its usages from the codebaseHow did you test it?
Notes for the reviewer
n/a
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.