Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark some unit tests under test/pipeline #5124

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jun 12, 2023

Proposed Changes:

  • As I noticed in another PR that almost no pipeline unit tests are run, this PR marks several unit tests under test/pipeline

How did you test it?

  • CI

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner June 12, 2023 14:27
@ZanSara ZanSara requested review from julian-risch and removed request for a team June 12, 2023 14:27
@ZanSara ZanSara changed the title chore: mark some unit tests as such chore: mark some unit tests under test/pipeline Jun 12, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jun 12, 2023

Pull Request Test Coverage Report for Build 5245533752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 41.933%

Totals Coverage Status
Change from base Build 5242553472: 1.0%
Covered Lines: 9406
Relevant Lines: 22431

💛 - Coveralls

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 I'm surprised we didn't notice that earlier. Good thing that you noticed it! 👍 No changes requested. One test was borderline unit test in my opinion though. The one testing that elasticsearch is not responding given a wrong port. Doesn't hurt but also isn't really testing something if there is no elasticsearch running anyway in a unit test.

test/pipelines/test_pipeline_yaml.py Outdated Show resolved Hide resolved
@ZanSara ZanSara merged commit 3c71f0a into main Jun 12, 2023
@ZanSara ZanSara deleted the pipeline-unit-tests branch June 12, 2023 15:58
@ZanSara ZanSara self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants