fix: rename requests.py into requests_utils.py
#5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Looks quite good to me already. One change is needed in the two tests: The @patch also needs to refer to the new module name requests_utils.
Pull Request Test Coverage Report for Build 5241662425
💛 - Coveralls |
masci
reviewed
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
squad_to_dpr.pycauses an errorAttributeError: partially initialized module 'requests' has no attribute 'Response' (most likely due to a circular import)#4880Proposed Changes:
requests.pyintorequests_utils.pyto avoid ambiguity at import timeHow did you test it?
Notes for the reviewer
n/a
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.