Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove audio node import #5097

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore: remove audio node import #5097

merged 1 commit into from
Jun 7, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jun 7, 2023

Related Issues

n/a

Proposed Changes:

  • I discovered some leftover optional imports for the audio nodes that were removed a few versions ago
  • This PR removes them.

How did you test it?

  • CI

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner June 7, 2023 12:51
@ZanSara ZanSara requested review from julian-risch and removed request for a team June 7, 2023 12:51
@ZanSara ZanSara self-assigned this Jun 7, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5200184738

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 40.74%
Files with Coverage Reduction New Missed Lines %
utils/import_utils.py 6 36.23%
Totals Coverage Status
Change from base Build 5199460578: -0.03%
Covered Lines: 9142
Relevant Lines: 22440
💛 - Coveralls

julian-risch
julian-risch approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will merge it.

@julian-risch julian-risch merged commit 5022abb into main Jun 7, 2023
@julian-risch julian-risch deleted the cleanup-audio-nodes-imports branch June 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees

@ZanSara ZanSara

Labels
topic:audio topic:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanSara @coveralls @julian-risch