-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Move Azure's Form Recognizer dependency to extras #5096
Conversation
Hey @julian-risch! There are no conditional/lazy imports to make after this dependency has moved into the extras? I think right now it doesn't seem like, but only because generalimport is hiding the failure. You may want to wait for #5084 so we're sure it's all working fine. |
Pull Request Test Coverage Report for Build 5242021282
💛 - Coveralls |
@ZanSara You mean adding sth like what we have for other imports relying on extras? try:
from azure.ai.formrecognizer import DocumentAnalysisClient, AnalyzeResult
from azure.core.credentials import AzureKeyCredential
except ImportError as exc:
logger.debug(
"azure.ai.formrecognizer or azure.core.credentials could not be imported. "
"Run 'pip install farm-haystack[file-conversion]' or 'pip install azure-ai-formrecognizer>=3.2.0b2' to fix this issue."
) |
Yes! I didn't check right now, but if they're already try-catched like in the snippet you shared, then it's alright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚢
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.