Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix doc for FARMReader.predict #5049

Merged
merged 1 commit into from
May 31, 2023
Merged

docs: Fix doc for FARMReader.predict #5049

merged 1 commit into from
May 31, 2023

Conversation

pcreux
Copy link
Contributor

@pcreux pcreux commented May 30, 2023

Proposed Changes:

Documentation lists offsets_in_context twice. It should be offsets_in_documents and offsets_in_context.

@pcreux pcreux requested a review from a team as a code owner May 30, 2023 14:09
@pcreux pcreux requested review from silvanocerza and removed request for a team May 30, 2023 14:09
@CLAassistant
Copy link

CLAassistant commented May 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added topic:reader type:documentation Improvements on the docs labels May 30, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5122543503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.581%
Totals Coverage Status
Change from base Build 5122190647: 0.0%
Covered Lines: 8848
Relevant Lines: 22354
💛 - Coveralls

@silvanocerza silvanocerza merged commit e209abd into deepset-ai:main May 31, 2023
@silvanocerza
Copy link
Contributor

Thanks @pcreux, really appreciated. 🙏

@pcreux pcreux deleted the fix-doc-farmreader-predict branch May 31, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic:reader type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcreux @CLAassistant @coveralls @silvanocerza