Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move check for default PromptTemplates in PromptTemplate itself #5018

Merged
merged 9 commits into from
May 27, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented May 24, 2023

Related Issues

  • fixes n/a

Proposed Changes:

  • Move check for default PromptTemplates in PromptTemplate itself to allow an API like PromptTemplate('summarization')

How did you test it?

local run

Notes for the reviewer

n/a

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@ZanSara ZanSara requested a review from vblagoje May 24, 2023 16:05
@ZanSara ZanSara marked this pull request as ready for review May 24, 2023 16:05
@ZanSara ZanSara requested a review from a team as a code owner May 24, 2023 16:05
@ZanSara ZanSara requested review from silvanocerza and removed request for a team May 24, 2023 16:05
@github-actions github-actions bot added the type:documentation Improvements on the docs label May 24, 2023
@ZanSara ZanSara self-assigned this May 24, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 24, 2023

Pull Request Test Coverage Report for Build 5098730429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 63 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 39.607%

Files with Coverage Reduction New Missed Lines %
nodes/prompt/prompt_template.py 20 88.76%
nodes/prompt/prompt_node.py 43 58.76%
Totals Coverage Status
Change from base Build 5093124690: -0.01%
Covered Lines: 8872
Relevant Lines: 22400

💛 - Coveralls

Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll get another boost in confidence signal once we rebase all pending PRs on top of this one.

@ZanSara ZanSara merged commit 7e5fa0d into main May 27, 2023
@ZanSara ZanSara deleted the default-prompttemplate-loading branch May 27, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants