Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate data and view for benchmarks #451

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Conversation

PiffPaffM
Copy link
Contributor

We will integrate the benchmarks into haystack.deepset.ai soon. Therefore, we need a new file format so that we can present the data as charts there. This way, website will download the data from master automatically and view the latest updates.

@PiffPaffM PiffPaffM self-assigned this Sep 30, 2020
},
"data": [
{
"model": "BM24 (Elasticsearch)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @PiffPaffM,
there is a typo here (BM24 -> BM25)

@tholor
Copy link
Member

tholor commented Oct 5, 2020

@brandenchan please review

Copy link
Contributor

@brandenchan brandenchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiffPaffM PiffPaffM merged commit 25f34ba into master Oct 6, 2020
@julian-risch julian-risch deleted the add_integration_benchmarks branch November 15, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants