Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Added Haystack_version variable in the docker build workflow. Before this change HAYSTACK_VERSION variable was getting "main" as the default value and every time it would take the "latest changes" from the "main" branch instead of the commit that is tagged with the specific version tag.
Notes for the reviewer
In case you want to verify, you can run following steps:
docker run -it --rm deepset/haystack:base-gpu-v0.0.7 python -c"import haystack;print(haystack.__version__)"
Expected output:
Status: Downloaded newer image for deepset/haystack:base-gpu-v0.0.7
0.0.7
How did you test it?
I manually added a dummy tag and ensured that the new image with the correct version was built and pushed.
Logs of Docker build action:
[base-cpu linux/amd64 build-image 4/9] RUN echo "Version check!!\n"
0.105 Version check!!
0.105
DONE 0.1s
[base-cpu linux/amd64 build-image 5/9] RUN echo v0.0.7
0.214 v0.0.7
DONE 0.3s
Checklist