-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include error message in HaystackError telemetry events #3543
Conversation
@vblagoje I committed the small changes that we discussed. In addition, one could add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 @vblagoje please also review the changes, thank you. Feel free to merge when you are done with your review.
Yes, LGTM as well. If CI is green, let's integrate it! |
Related Issues
Proposed Changes:
Added a message field to all HaystackError(s) raised. If set message property will be visible in telemetry
How did you test it?
Manual verification, there is no other way.
Notes for the reviewer
Someone familiar with telemetry needs to review. Otherwise, the context is rather big and requires time to pick up.
Checklist