feat: Speed up reader tests #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrl
force-pushed
the
sjrl-tests-speed
branch
from
d0a6c50 to
f0f17c3
Compare
bogdankostic
approved these changes
Oct 26, 2022
| assert metrics_top_2["Retriever"]["mrr"] == 0.5 | ||
| assert metrics_top_2["Retriever"]["map"] == 0.5 | ||
| assert metrics_top_2["Retriever"]["recall_multi_hit"] == 0.5 | ||
| assert metrics_top_2["Retriever"]["recall_single_hit"] == 0.5 | ||
| assert metrics_top_2["Retriever"]["precision"] == 0.1 | ||
| assert metrics_top_2["Retriever"]["ndcg"] == 0.5 | ||
|
|
||
| metrics_top_3 = eval_result.calculate_metrics(simulated_top_k_reader=3, document_scope="document_id") | ||
| metrics_top_5 = eval_result.calculate_metrics(simulated_top_k_reader=5, document_scope="document_id") |
There was a problem hiding this comment.
Any specific reason why you changed simulated_top_k_reader here to 5?
There was a problem hiding this comment.
Good question. The metrics only changed and became better when changing it to 5 here. Keeping it at 3 would have required the metrics to be changed to match the ones when using the simulated_top_k_reader of 1 and 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Changed the reader fixture in
conftest.pyto use a smaller reader (500mb to ~165mb) model that still produces sensible results. This will help to speed up tests and slightly reduce the disk space usage for downloading models.How did you test it?
Updated the existing unit tests to work with the new smaller reader. The only real changes needed to happen when comparing metrics of the reader performance. They changed slightly which is to be expected.
Notes for the reviewer
Checklist