fix: disabling telemetry prevents writing config

[julian-risch]

Related Issues

• fixes Telemetry can't be fully disabled #3439

Proposed Changes:

This PR adds a check before writing the telemetry config file. If telemetry is disabled, this file is not written. As a consequence no event will be sent (not even a file event that telemetry is turned off).

Previously, if no config file existed and telemetry was disabled via an environment variable, it could happen that a new user id was generated and stored in a config file. As a consequence a final event was sent, which causes the error

ERROR:posthog:error uploading: HTTPSConnectionPool(host='tm.hs.deepset.ai', port=443): Max retries exceeded with url: /batch/ (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f07b4173c70>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

if there is no internet connection.

How did you test it?

locally by running:

rm ~/.haystack/config.yaml
export HAYSTACK_TELEMETRY_ENABLED=False
python
from haystack.document_stores import InMemoryDocumentStore
document_store = InMemoryDocumentStore()

Notes for the reviewer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added tests that demonstrate the correct behavior of the change
• I've used the conventional commit convention for my PR title
• I documented my code
• I ran pre-commit hooks and fixed any issue

[ZanSara]

Looks good! Approving after the nitpick 😁