Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove YAML save/load methods for subclasses of BaseStandardPipeline #3443

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Oct 20, 2022

Related Issues

Proposed Changes:

  • Remove the save_to_yaml and load_from_yaml methods for BaseStandardPipeline. They were half-baked and easily replaceable with a more meaningful call to standard_pipeline.pipeline.save_to_yaml/Pipeline.load_from_yaml
    • Rationale: the saved/loaded pipeline is a standard Pipeline anyway. No checks are performed at any stage. So one could load an indexing pipeline with ExtractiveQAPipeline.load_from_yaml and obtain an ExctractiveQAPipeline object that behaves like an indexing pipeline.
  • Update the documentation in Pipeline.load_from_yaml

How did you test it?

  • CI

Notes for the reviewer

  • This PR is only vaguely related with the referenced issue. The main rationale is explained in the Proposed Changes section.

Checklist

@ZanSara ZanSara added type:bug Something isn't working topic:pipeline type:refactor Not necessarily visible to the users type:documentation Improvements on the docs labels Oct 20, 2022
@ZanSara ZanSara marked this pull request as ready for review October 20, 2022 13:27
@ZanSara ZanSara requested a review from a team as a code owner October 20, 2022 13:27
@ZanSara ZanSara requested review from bogdankostic and removed request for a team October 20, 2022 13:27
@bogdankostic
Copy link
Contributor

I think we need to rebase to make the pylint check pass.

Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanSara ZanSara merged commit bb1d998 into main Nov 2, 2022
@ZanSara ZanSara deleted the remove-standard-pipeline-yaml branch November 2, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:pipeline type:bug Something isn't working type:documentation Improvements on the docs type:refactor Not necessarily visible to the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants