Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Speed up integration tests (nodes) #3408

Merged
merged 3 commits into from
Oct 18, 2022
Merged

feat: Speed up integration tests (nodes) #3408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b5d272
Changed summarizer model to a smaller one (2GB to 500MB) to save on s…
sjrl Oct 18, 2022
e26c63a
Removed google pegasus from cache
sjrl Oct 18, 2022
86b7ffa
Reactivated test that wasn't run b/c it was named incorrectly
sjrl Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ def lfqa_generator(request):

@pytest.fixture
def summarizer():
return TransformersSummarizer(model_name_or_path="google/pegasus-xsum", use_gpu=-1)
return TransformersSummarizer(model_name_or_path="sshleifer/distilbart-xsum-12-6", use_gpu=False)


@pytest.fixture
Expand Down
10 changes: 5 additions & 5 deletions test/nodes/test_summarizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
]

EXPECTED_SUMMARIES = [
"California's largest electricity provider has turned off power to hundreds of thousands of customers.",
"The Eiffel Tower is a landmark in Paris, France.",
"California's largest electricity provider, PG&E, has shut down power supplies to thousands of customers.",
" The Eiffel Tower in Paris has officially opened its doors to the public.",
]

SPLIT_DOCS = [
Expand All @@ -32,8 +32,8 @@
# Documents order is very important to produce summary.
# Different order of same documents produce different summary.
EXPECTED_ONE_SUMMARIES = [
"The Eiffel Tower is a landmark in Paris, France.",
"The Eiffel Tower, built in 1889 in Paris, France, is the world's tallest free-standing structure.",
" The Eiffel Tower in Paris has officially opened its doors to the public.",
" The Eiffel Tower in Paris has become the tallest man-made structure in the world.",
]


Expand Down Expand Up @@ -89,7 +89,7 @@ def test_summarization_pipeline(document_store, retriever, summarizer):
output = pipeline.run(query=query, params={"Retriever": {"top_k": 1}})
answers = output["answers"]
assert len(answers) == 1
assert "The Eiffel Tower is a landmark in Paris, France." == answers[0]["answer"]
assert " The Eiffel Tower in Paris has officially opened its doors to the public." == answers[0]["answer"]


@pytest.mark.integration
Expand Down
4 changes: 2 additions & 2 deletions test/nodes/test_summarizer_translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ def test_summarization_pipeline_with_translator(
documents = output["documents"]
assert len(documents) == 1
assert documents[0].content in [
"Der Eiffelturm ist ein Wahrzeichen in Paris, Frankreich.",
"Der Eiffelturm, der 1889 in Paris, Frankreich, erbaut wurde, ist das höchste freistehende Bauwerk der Welt.",
"Der Eiffelturm in Paris ist die höchste von Menschen geschaffene Struktur der Welt geworden.",
"Der Eiffelturm in Paris hat offiziell seine Türen für die Öffentlichkeit geöffnet.",
]