fix: allow same vector_id
in different indexes for SQL-based Document stores
#3383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
In
SQLDocumentStore
:vector_id
is no longer uniqueUniqueConstraint
forindex
+vector_id
In
FAISSDocumentStore
:update_embeddings
method to take this change into account.Now for every index,
vector_id
starts at 0How did you test it?
pytest . --document_store_type="sql,faiss"
SQLDocumentStore
andFAISSDocumentStore
Notes for the reviewer
Checklist