fix: opensearch script score with filters #3321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
OpenSearchDocumentStore
script score query with filters is invalid #3320Proposed Changes:
set filter properly according to https://opensearch.org/docs/latest/search-plugins/knn/knn-score-script/
How did you test it?
Notes for the reviewer
I thought about adding the filters logic to
_get_vector_similarity_query
, however this also need refactoring ofElastisearchDocumentStore
. Given that there is already a PR for betterscript_score
support underway in #3284 I kept the changes to a minimum.Checklist