Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed for SQLDocumentStore #330

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Improve speed for SQLDocumentStore #330

merged 4 commits into from
Aug 21, 2020

Conversation

tanaysoni
Copy link
Contributor

Resolves #329

@tanaysoni tanaysoni changed the title Improve speed for SQLDocumentStore WIP: Improve speed for SQLDocumentStore Aug 20, 2020
@tanaysoni tanaysoni requested a review from tholor August 20, 2020 13:57
@tanaysoni tanaysoni changed the title WIP: Improve speed for SQLDocumentStore Improve speed for SQLDocumentStore Aug 20, 2020
tholor
tholor approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Speed is down to < 500ms again (tested locally with sqllite on 1000 docs)

@tholor tholor added topic:faiss type:bug Something isn't working labels Aug 21, 2020
@tanaysoni tanaysoni merged commit 7d2a8f1 into master Aug 21, 2020
@tanaysoni tanaysoni deleted the sql-doc-store-performance branch August 21, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
topic:faiss type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow FAISSDocumentStore due to SQL bottleneck
2 participants
@tanaysoni @tholor