chore: remove tutorials from the repo #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
masci
force-pushed
the
massi/tutorials
branch
from
73c0867 to
b23c1dc
Compare
masci
changed the title
|
Looks good, however the legacy tutorials under docs/ versions have colab buttons that point to these ones. They either have to be updated here or in haystack-website (although the repo is ignored in haystack-website). Let me know which way to go about it and I'll be happy to update them |
|
@TuanaCelik do you have an easy way to search and replace all the old versions? If yes you can open a PR with the fix, we merge and I rebuild the old website one last time before switching to the new build script |
ZanSara
approved these changes
Sep 20, 2022
Comment on lines
-9
to
-11
| <a href="https://github.com/deepset-ai/haystack/actions/workflows/tutorials_nightly.yml"> | ||
| <img alt="Tutorials" src="https://github.com/deepset-ai/haystack/actions/workflows/tutorials_nightly.yml/badge.svg"> | ||
| </a> |
There was a problem hiding this comment.
Do you think we can replace this with a badge from the other repo?
Suggested change
| <a href="https://github.com/deepset-ai/haystack/actions/workflows/tutorials_nightly.yml"> | |
| <img alt="Tutorials" src="https://github.com/deepset-ai/haystack/actions/workflows/tutorials_nightly.yml/badge.svg"> | |
| </a> | |
| <a href="https://github.com/deepset-ai/haystack/actions/workflows/tutorials_nightly.yml"> | |
| <img alt="Tutorials" src="https://github.com/deepset-ai/haystack-tutorials/actions/workflows/nightly.yml/badge.svg"> | |
| </a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Moving tutorials to https://github.com/deepset-ai/haystack-tutorials
How did you test it?
Notes for the reviewer
Checklist